Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shuffle pyx functions noexcept #477

Merged
merged 6 commits into from Oct 17, 2023

Conversation

martindurant
Copy link
Member

@martindurant martindurant commented Oct 10, 2023

Fixes #476

@jakirkham , like this? The functions don't actually return anything.

Do we have any process to determine which codecs release the GIL? Given the performance discussions, this could be imporant.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #477 (975d45b) into main (1bc1e44) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #477      +/-   ##
===========================================
+ Coverage   99.95%   100.00%   +0.04%     
===========================================
  Files          56        56              
  Lines        2241      2242       +1     
===========================================
+ Hits         2240      2242       +2     
+ Misses          1         0       -1     

see 2 files with indirect coverage changes

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Martin! 🙏

IIUC adding noexcept should be sufficient here (looking at this Cython doc section)

numcodecs/_shuffle.pyx Outdated Show resolved Hide resolved
numcodecs/_shuffle.pyx Outdated Show resolved Hide resolved
martindurant and others added 3 commits October 17, 2023 10:41
Co-authored-by: jakirkham <jakirkham@gmail.com>
Co-authored-by: jakirkham <jakirkham@gmail.com>
@jakirkham jakirkham changed the title Make shuffle pyx functions return int Make shuffle pyx functions noexcept Oct 17, 2023
@jakirkham
Copy link
Member

Thanks Martin! 🙏

@jakirkham jakirkham enabled auto-merge (squash) October 17, 2023 20:03
@jakirkham jakirkham merged commit c28f5c9 into zarr-developers:main Oct 17, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_doShuffle: Cython performance hint regarding GIL usage
2 participants