Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change non-string attribute key from warning to error #1125

Open
joshmoore opened this issue Sep 8, 2022 · 5 comments
Open

Change non-string attribute key from warning to error #1125

joshmoore opened this issue Sep 8, 2022 · 5 comments
Labels
maintenance Work needed by a maintainer

Comments

@joshmoore
Copy link
Member

joshmoore commented Sep 8, 2022 •
edited
Loading

follow-up to #1037 #1066 to perform the breaking change that we were not yet ready to make:

z1.attrs.put({1: "bar", "foo": "bar"})  # Error
@joshmoore joshmoore mentioned this issue Sep 8, 2022
Closed
@MSanKeys963 MSanKeys963 added the good-first-issue Good place to get started as a new contributor. label Oct 11, 2022
@I-am-Emmanuel
Copy link

It will be my pleasure to work on this issue.

@I-am-Emmanuel
Copy link

I recently completed this project. Waiting to be merged

@MSanKeys963
Copy link
Member

MSanKeys963 commented Oct 13, 2022 •
edited
Loading

Hi @I-am-Emmanuel. Thanks for working on this.
We'll review your PR #1183.

@joshmoore joshmoore removed the good-first-issue Good place to get started as a new contributor. label Oct 13, 2022
@MSanKeys963 MSanKeys963 added the maintenance Work needed by a maintainer label Oct 13, 2022
@MSanKeys963
Copy link
Member

MSanKeys963 commented Oct 13, 2022 •
edited
Loading

Hi @I-am-Emmanuel.
After going through the issue, I realised this issue is a breaking change and needs to be handled by the maintainers for the Zarr python only.
I think I added the good-first-issue label accidentally, and I sincerely apologise for that. 🙏🏻

Can you please work on another issue? I'm happy to help you find one if you can't find one.

@I-am-Emmanuel
Copy link

Alright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Work needed by a maintainer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshmoore @MSanKeys963 @I-am-Emmanuel