Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codecov #1391

Merged
merged 1 commit into from Apr 13, 2023
Merged

Remove codecov #1391

merged 1 commit into from Apr 13, 2023

Conversation

jakirkham
Copy link
Member

Fixes #1390

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #1391 (c2385ef) into main (4b0705c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1391   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        37    +1     
  Lines        14799     14855   +56     
=========================================
+ Hits         14799     14855   +56     
Impacted Files Coverage Δ
zarr/_storage/store.py 100.00% <100.00%> (ø)
zarr/context.py 100.00% <100.00%> (ø)
zarr/core.py 100.00% <100.00%> (ø)
zarr/storage.py 100.00% <100.00%> (ø)
zarr/tests/test_storage.py 100.00% <100.00%> (ø)
zarr/tests/test_storage_v3.py 100.00% <100.00%> (ø)
zarr/tests/test_util.py 100.00% <100.00%> (ø)
zarr/tests/util.py 100.00% <100.00%> (ø)
zarr/util.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@jakirkham
Copy link
Member Author

@MSanKeys963 looks like this works 🎉 Going to go ahead and merge to fix CI

@jakirkham jakirkham enabled auto-merge (squash) April 13, 2023 20:51
@jakirkham jakirkham disabled auto-merge April 13, 2023 20:51
@jakirkham jakirkham merged commit e1e5561 into zarr-developers:main Apr 13, 2023
19 checks passed
@jakirkham jakirkham deleted the rm_codecov branch April 13, 2023 20:52
@MSanKeys963
Copy link
Member

MSanKeys963 commented Apr 13, 2023

Thanks, @jakirkham! 🙏🏻

Also, sent a PR for adding this in the upcoming release notes, #1392.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove codecov
2 participants