Unnecessary list literal → set literal #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1534 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 14735 14735
=========================================
Hits 14735 14735
|
|
This looks good. just needs release notes. let me know if you want me to write them. |
|
I've added a release note. |
github-actions
bot
removed
the
needs release notes
DimitriPapadopoulos
force-pushed
the
unnecessary_list_literal
branch
from
0210688
to
061f678
Compare
Why use a list literal to initialise a set? Just use a set literal.
Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
DimitriPapadopoulos
force-pushed
the
unnecessary_list_literal
branch
from
061f678
to
39877a2
Compare
d-v-b
approved these changes
Oct 26, 2023
dstansby
pushed a commit
to dstansby/zarr-python
that referenced
this pull request
Oct 31, 2023
* Unnecessary list literal → set literal Why use a list literal to initialise a set? Just use a set literal. * Add release note for previous commit Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> --------- Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why use a list literal to initialise a set? Just use a set literal.
It's also consistent with the previous line:
zarr-python/zarr/tests/test_storage.py
Line 1167 in 6ec746e
TODO: