Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.8 and numpy 1.20 #1557

Merged
merged 9 commits into from Jan 10, 2024
Merged

Conversation

joshmoore
Copy link
Member

@joshmoore joshmoore commented Oct 31, 2023

Various PR builds (e.g. https://github.com/zarr-developers/zarr-python/actions/runs/6704243768/job/18216294128?pr=1543) are failing on Python 3.8. According to https://scientific-python.org/specs/spec-0000/ dropping Python 3.9 is suggested by the end of this year. As a step in that direction, this PR drops 3.8 and adds 3.12.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Oct 31, 2023
@joshmoore
Copy link
Member Author

joshmoore commented Oct 31, 2023

Note: green builds will require updating the GitHub settings

image

@d-v-b
Copy link
Contributor

d-v-b commented Oct 31, 2023

this is great idea, thank you

@joshmoore
Copy link
Member Author

joshmoore commented Oct 31, 2023

May have been a bit premature with 3.12...

      error: command '/usr/bin/gcc' failed with exit code 1
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for line_profiler

see: pyutils/line_profiler#247

@joshmoore joshmoore changed the title Drop 3.8 and add 3.12 Drop python 3.8 and numpy 1.20 Oct 31, 2023
@joshmoore
Copy link
Member Author

All non-3.8 builds have passed. I think this is in a fine state. @jakirkham, any thoughts, after you recently added 3.12 to numcodecs but didn't drop 3.8?

@jhamman
Copy link
Member

jhamman commented Dec 7, 2023

+1 on dropping 3.8 then 3.9 early next year. @joshmoore - can we help you get this over the line?

.github/workflows/releases.yml Show resolved Hide resolved
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Dec 26, 2023
@joshmoore
Copy link
Member Author

I accepted your change, @jhamman, and merged in main. Assuming all is green, I imagine we can get this in immediately (unless we want one last pre-drop release).

@jhamman
Copy link
Member

jhamman commented Dec 26, 2023

I accepted your change, @jhamman, and merged in main. Assuming all is green, I imagine we can get this in immediately (unless we want one last pre-drop release).

I don't think that is necessary. Let's merge when this goes green!

@jhamman
Copy link
Member

jhamman commented Dec 27, 2023

@joshmoore - any idea why the last few checks have not reported back?

@joshmoore
Copy link
Member Author

Got a (big) verbal 👍 from @jakirkham. The failing jobs are due to the job configuration re: #1557 (comment)

I'll merge now and bump the 3.8s to 3.9s.

@joshmoore joshmoore merged commit c7d66b4 into zarr-developers:main Jan 10, 2024
18 checks passed
@joshmoore joshmoore deleted the 3_12 branch January 10, 2024 19:52
@joshmoore
Copy link
Member Author

For now I've bumped the Windows and just removed the build items since the new versions hadn't been built yet:

image

jhamman added a commit to jhamman/zarr-python that referenced this pull request Jan 24, 2024
* Drop 3.8 and add 3.12

* Try removing line_profiler

* Also bump the minimal numpy to 1.21

* Drop 3.12 again

* Revert "Try removing line_profiler"

This reverts commit 837854b.

* Update release.rst

---------

Co-authored-by: Joe Hamman <joe@earthmover.io>
Co-authored-by: jakirkham <jakirkham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants