Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency #1563

Merged
merged 2 commits into from Nov 3, 2023
Merged

Remove dependency #1563

merged 2 commits into from Nov 3, 2023

Conversation

MSanKeys963
Copy link
Member

Fixes: #1552.

TODO:

  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Nov 2, 2023
jakirkham
jakirkham reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sanket! 🙏

Had one suggestion below

pyproject.toml Outdated Show resolved Hide resolved
joshmoore
joshmoore reviewed Nov 3, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@joshmoore joshmoore merged commit 889d285 into zarr-developers:main Nov 3, 2023
14 of 16 checks passed
@MSanKeys963 MSanKeys963 deleted the rtd_theme branch December 27, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmoore joshmoore joshmoore left review comments

@jakirkham jakirkham jakirkham left review comments

Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop sphinx-rtd-theme dependency
3 participants
@MSanKeys963 @joshmoore @jakirkham