Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v1 and v2 specification #1582

Merged
merged 5 commits into from Mar 29, 2024

Conversation

MSanKeys963
Copy link
Member

Hi everyone. πŸ‘‹πŸ»

Following this from zarr-developers/zarr-specs#276, I removed the v1 and v2 specification from https://zarr.readthedocs.io/en/stable/spec.html.

For now, I've added this message for redirecting:

The V1/2/3 Specification has been migrated to its website β†’
https://zarr-specs.readthedocs.io/.

Please note: We can add specific redirects for individual pages; see this: https://docs.readthedocs.io/en/stable/user-defined-redirects.html#user-defined-redirects.

User-defined redirects can be added via the readthedocs.org dashboard.

TODO:

  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Nov 28, 2023
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Nov 28, 2023
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MSanKeys963 - let's get zarr-developers/zarr-specs#276 in then merge this.

@@ -1521,11 +1521,11 @@ Bug fixes
Documentation
~~~~~~~~~~~~~

* Some changes have been made to the :ref:`spec_v2` document to clarify
* Some changes have been made to the Zarr Specification v2 document to clarify
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this a hyperlink to the zarr-specs page

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, once we merge zarr-developers/zarr-specs#276, I'll add the link here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MSanKeys963 - I think you could take that PR over. Looks like its just a few minor edits remaining.

@jhamman jhamman merged commit cb5b77a into zarr-developers:main Mar 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants