Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTD build #1694

Merged
merged 5 commits into from Mar 6, 2024
Merged

Fix RTD build #1694

merged 5 commits into from Mar 6, 2024

Conversation

MSanKeys963
Copy link
Member

@MSanKeys963 MSanKeys963 commented Mar 6, 2024

Fixes #1680.

I did a lil' investigation, and it seems like the RTD builds started failing on the mainline after #1560.
This is the last successful build and this is where it started failing.

I've noticed that RTD throws an error when it tries to build the epub format of the documentation:
python -m sphinx -T -W --keep-going -b epub -d _build/doctrees -D language=en . $READTHEDOCS_OUTPUT/epub

TODO:

  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@MSanKeys963 MSanKeys963 mentioned this pull request Mar 6, 2024
6 tasks
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some background on why you think this will improve the situation would be interesting but I very much doubt anyone is depending on the ePub. 👍🏼

@joshmoore joshmoore merged commit 240bb82 into zarr-developers:main Mar 6, 2024
17 checks passed
@MSanKeys963 MSanKeys963 deleted the fix_rtd_build branch March 6, 2024 15:40
@MSanKeys963
Copy link
Member Author

Sure. Updated the PR description.

@joshmoore
Copy link
Member

Sure. Updated the PR description.

Appreciated. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readthedocs doc build failing on main
2 participants