Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to skip ndbm in coverage. #682

Merged
merged 1 commit into from Jan 1, 2021
Merged

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Jan 1, 2021

NDBM is not package by conda on non-mac; so it's hard to test on github action.
Marking as skip to try to get coverage back to 100%

@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #682 (8ea165e) into master (aa786cb) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   99.50%   99.55%   +0.04%     
==========================================
  Files          29       29              
  Lines       10127    10122       -5     
==========================================
  Hits        10077    10077              
+ Misses         50       45       -5     
Impacted Files Coverage Δ
zarr/storage.py 99.17% <ø> (+0.40%) ⬆️

@Carreau
Copy link
Contributor Author

Carreau commented Jan 1, 2021

This increase coverage; merging.

@Carreau Carreau merged commit f6095be into zarr-developers:master Jan 1, 2021
@Carreau Carreau deleted the skip-ndbm branch January 1, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant