Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize_keys regression in version 2.10.0 #841

Closed
d70-t opened this issue Sep 28, 2021 · 3 comments
Closed

normalize_keys regression in version 2.10.0 #841

d70-t opened this issue Sep 28, 2021 · 3 comments

Comments

@d70-t
Copy link
Contributor

d70-t commented Sep 28, 2021

In dca87fc (#793), the normalize_keys parameter default of FSStore has been changed back to from False to True (see here). This reverts #755 and recreates the issue of #739.

I didn't find a comment on this in the commit message and believe this was done by accident.
@joshmoore
Copy link
Member

Thanks, @d70-t for all the sleuthing, and sorry if I let something slip through. @d-v-b: can you say if it was intentional or not?

@d-v-b
Copy link
Contributor

d-v-b commented Sep 28, 2021

this looks like my mistake! I can whip up a quick fix.

@d-v-b d-v-b mentioned this issue Sep 28, 2021
Merged
@d-v-b
Copy link
Contributor

d-v-b commented Sep 28, 2021

see #842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshmoore @d-v-b @d70-t