Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fallback data types from specification #248

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

jbms
Copy link
Contributor

@jbms jbms commented Jun 29, 2023

None of the completed/in-progress implementations have implemented fallback data type support, to my knowledge, and they can't really be implemented based on the current spec given that it is not specified how fill values are handled if a fallback data type is used.

@jbms
Copy link
Contributor Author

jbms commented Jul 6, 2023

@normanrz Please take a look.

jstriebel
jstriebel previously approved these changes Jul 18, 2023
Copy link
Member

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think this will be a useful addition once more data-type extensions exist, and we will rather need to figure out how to handle the fill value then. But fair to remove it for now. Mostly LGTM, just left one minor comment about the changelog entry.

docs/v3/core/v3.0.rst Outdated Show resolved Hide resolved
None of the completed/in-progress implementations have implemented
fallback data type support, to my knowledge, and they can't really be
implemented based on the current spec given that it is not specified
how fill values are handled if a fallback data type is used.
@jbms jbms force-pushed the remove-fallback-data-type branch from 65c8bc5 to cc1d163 Compare July 27, 2023 17:02
@jbms
Copy link
Contributor Author

jbms commented Jul 27, 2023

Fixed changelog entry.

@jbms jbms merged commit f7c5534 into zarr-developers:main Jul 27, 2023
1 check passed
@jbms jbms deleted the remove-fallback-data-type branch July 27, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants