Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement read tests for non python implementations #25

Open
constantinpape opened this issue Mar 24, 2021 · 7 comments
Open

Implement read tests for non python implementations #25

constantinpape opened this issue Mar 24, 2021 · 7 comments

Comments

@constantinpape
Copy link
Collaborator

constantinpape commented Mar 24, 2021

Currently, we only check that data can be read with the python libraries (zarr-python, z5py, pyn5).
We should also implement read tests for the non-python libraries though:

I can implement the n5-java test at some point (but probably won't have time in the next 3 weeks.)

@joshmoore
Copy link
Member

joshmoore commented Apr 22, 2021

What strategy were you thinking? A subprocess call from test_read_all.py? Or do we add a test runner for each language? e.g. junit or testng for Java and cppunit or gtest for C++? (Anyone have a completely different strategy?)

@constantinpape
Copy link
Collaborator Author

I think a subprocess call in test_read_all.py is a good solution.
That's also done in the PR for reading with xtensor, see #34.

@joshmoore
Copy link
Member

👍 I'll give this a try.

@constantinpape
Copy link
Collaborator Author

+1 I'll give this a try.

Cool!

Just note that the one for xtensor is already under way in #34 and just pending some fixes I have to make in z5. I am looking into this today.

@joshmoore
Copy link
Member

Noted. I'll deal with any conflicts. An issue with the strategy in #34 will be how to get a npy from Java. Seems like that will introduce a new class of possible errors.

@constantinpape
Copy link
Collaborator Author

Can you use kotlin on the java side? Because this seems fairly well tested: https://github.com/JetBrains-Research/npy

@grlee77
Copy link
Contributor

grlee77 commented Apr 27, 2021

Can you use kotlin on the java side? Because this seems fairly well tested: https://github.com/JetBrains-Research/npy

Ah, I had missed this discussion, but this is the same library I happened to find today and mention in #37 (comment). However I see now that in the README at that repository it states that unsigned integer types are currently not supported, so that would be a problem for our current test data here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants