Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include nested/flat tests #26

Open
joshmoore opened this issue Mar 26, 2021 · 4 comments
Open

Include nested/flat tests #26

joshmoore opened this issue Mar 26, 2021 · 4 comments

Comments

@joshmoore
Copy link
Member

see: zarr-developers/zarr-python#707

Most implementations support the choice of . or / as a dimension separator. The arguments for readers and writers could be: default, ., /. Auto-detection would be a potential other option depending on what is decided on 707.

Note: this may be the beginning of introducing many other dimensions to the test matrix.

@grlee77
Copy link
Contributor

grlee77 commented Apr 14, 2021

I started looking at this.

zarrita: can generate either flat or nested

zarr-python: can generate v2 files with nested format when using FSStore instead of the default DirectoryStore.

xtensor-zarr: it looks like it is possible to generate flat or nested for v3, but in the v2 spec case the '.' separator is currently hard-coded.

The n5 format does not seem to support a flat storage scheme

@joshmoore
Copy link
Member Author

Sounds about right. A few notes:

@davidbrochart
Copy link
Contributor

Perhaps @davidbrochart would be up for adding it to v2 as well based on zarr-developers/zarr-python#715?

Sure, that should be easy.

@joshmoore
Copy link
Member Author

zarr-developers/zarr-python#716 is now merged and released. I'd assume for all participating implementations, the behavior shoudl be:

  • writer uses default --> .zarray with no dimension_separator --> reader uses "."
  • writer uses "." --> .zarray with dimension_separator="." --> reader uses "."
  • writer uses "/" --> .zarray with dimension_separator="/" --> reader uses "/"

and in all three cases something other than fill_value should be returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants