Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid writing .smb file for JITed main module #18

Closed
tenko opened this issue Mar 14, 2024 · 2 comments
Closed

Avoid writing .smb file for JITed main module #18

tenko opened this issue Mar 14, 2024 · 2 comments

Comments

@tenko
Copy link
Collaborator

tenko commented Mar 14, 2024

I modified line 41 in Sema.cpp:

if (logger_.getErrorCount() == 0 && !config_.isJit()) {

This seems logical to add to me.
@zaskar9
Copy link
Owner

zaskar9 commented Mar 15, 2024

Yes, that's a reasonable change in my opinion. I was already getting annoyed by the *.smb files piling up in my unittests folder.

@tenko
Copy link
Collaborator Author

tenko commented Mar 15, 2024

Excellent. Change implemented in pull request #19 .

@zaskar9 zaskar9 closed this as completed Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tenko @zaskar9