Swift 4.2 and Xcode 10 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgoldsby
force-pushed
the
xcode10
branch
2 times, most recently
from
147d58b
to
d49c18a
Compare
dcordero
approved these changes
Oct 16, 2018
|
I don't have a strong opinion on this. From the very small sampling I've done, I saw other projects release their Swift 4.2 updates as a minor version. I think we can make a small note about Swift 4.2 and Xcode 10 compatibility on our release page to communicate compatibility requirements. |
|
🎩 Sounds like a plan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated TvOSSlider to Xcode 10 and Swift 4.2.
I did not bump the version in the podspec.
I also saw that other repos are removing the
.swift-versionfile.