Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scss variables #14

Closed
matmkian opened this issue Jan 5, 2015 · 5 comments
Closed

Add scss variables #14

matmkian opened this issue Jan 5, 2015 · 5 comments
Milestone

Comments

@matmkian
Copy link

matmkian commented Jan 5, 2015

Hi,

First I'd like to thank you for your great work !

It would be great if you can provide scss/less variables for each icon.
We could use it with pseudo element.

$md-var-arrow-drop-up: '\f296';

.up-button:after {
    content: $md-var-arrow-drop-up;
}
@ArthurClemens
Copy link

I am in favor of this. I would like the option to extend the icons. For FontAwesome I am doing this:

.btn-bookmark {
    .extend_icon(fa, fa-var-bookmark);
}

.extend_icon(fa, @name) {
    &:before {
        &:extend(.fa-icon);
        content: @@name;
    }
}

This is possible because FA defines a variable for each character code.

For MD I would need to pass the character code: .extend_icon(md, "\f019"). Codes are likely to break, and they are hard to understand from reading the code.

@pine3ree
Copy link

👍
fa variables are very useful, fixed-width class too...

@ArthurClemens
Copy link

This project looks abandoned.

@pine3ree
Copy link

i just added a PR for this (sass version): #37
please download the master repo in my account and test before using it!!!
If you find any error please let me know or issue a PR directly into my repo.
kind regards.

@zavoloklom zavoloklom modified the milestones: ver2, 2.0.0 Jun 18, 2015
@zavoloklom
Copy link
Owner

Fixed in 2.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants