Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"!default" not used properly in version 2.0.0 #45

Closed
cgx opened this issue Jun 19, 2015 · 3 comments
Closed

"!default" not used properly in version 2.0.0 #45

cgx opened this issue Jun 19, 2015 · 3 comments
Labels
Milestone

Comments

@cgx
Copy link

cgx commented Jun 19, 2015

From the Changelog of release 2.0.0:

add "!default" to sass variables;

However, !default is assigned to CSS declarations, not SASS variables. libsass doesn't like it.

See the SASS documentation.

@zavoloklom
Copy link
Owner

Basicly I don't use SASS, I use LESS.
So I don't understand what actualy i'm doing wrong cause i follow issue #26 and pull requests #19, #23 and #25 recommendations.
Can you give me an example of what you think i should do in this files?
https://github.com/zavoloklom/material-design-iconic-font/blob/master/scss/_variables.scss
https://github.com/zavoloklom/material-design-iconic-font/blob/master/scss/_icons.scss

@cgx
Copy link
Author

cgx commented Jun 19, 2015

Those two files are correct. The problems are in _sizes.scss, _stacked.scss and _rotated.scss.

Simply remove the !default in those three files.

@zavoloklom
Copy link
Owner

Fixed in v2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants