Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Lint pull request files #8

Closed
zbeekman opened this issue Jul 1, 2019 · 0 comments · Fixed by #18
Closed

RFE: Lint pull request files #8

zbeekman opened this issue Jul 1, 2019 · 0 comments · Fixed by #18
Assignees
Labels
enhancement New feature or request outdated

Comments

@zbeekman
Copy link
Owner

zbeekman commented Jul 1, 2019

Is your feature request related to a problem? Please describe.

When not linting all files, EC lint failures in older commits will pass if the failing file is not touched in more recent commits. This is definitely not good for pull requests.

Describe the solution you'd like

When not linting all files, pull requests should trigger actions to lint all touched files in the pull request. This is probably a simple matter of adding an option for watching a pull-request event.

Describe alternatives you've considered

The only real alternative is to lint everything

@zbeekman zbeekman added the enhancement New feature or request label Jul 1, 2019
@zbeekman zbeekman self-assigned this Jul 1, 2019
@lock lock bot added the outdated label Jul 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request outdated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant