Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReRun the modified code #9

Open
Soudeh-Jahanshahi opened this issue Apr 10, 2024 · 1 comment
Open

ReRun the modified code #9

Soudeh-Jahanshahi opened this issue Apr 10, 2024 · 1 comment

Comments

@Soudeh-Jahanshahi
Copy link
Contributor

Soudeh-Jahanshahi commented Apr 10, 2024

Everything works fine.

My only concern is about the order of hyperparameter sets which is different from hyperparameters_doc2vec.json, which is the same JSON file that I used for Word2Vec models where sg was replaced by dm.

For instance, the first 9 hyperparameter sets are for dm=0, while in hyperparameters_doc2vec.json, the even sets are for dm=0.

@Soudeh-Jahanshahi Soudeh-Jahanshahi changed the title Check the modified code ReRun the modified code Apr 10, 2024
@Soudeh-Jahanshahi
Copy link
Contributor Author

Soudeh-Jahanshahi commented Apr 11, 2024

I want to add to this report my second concern:

  • The code exhibits inefficiency in memory usage, unnecessarily consuming additional memory by saving a single embedding file for every document via function create_document_embeddings of script embeddings.py: Last week when I executed the compact-code on de-NBI cloud I could get the results of all 18 sets at once, but using this new modified code I just had space to get the results of first 6 sets at once ...

And I really enjoyed using script show_avg.py, which produces a summary table of average results of all sets for each evaluation quantity --the same as the tables that we should fill in the spreadsheets-- and save it as a tsv file: So far I did fill all my tables in the spreadsheets row by row :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant