-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please stop deleting closed biz POIs #222
Comments
And ideally OsmApp should have a straightforward way to report that business was replaced rather than closed (#223) |
See https://github.com/streetcomplete/StreetComplete/blob/master/app/src/main/java/de/westnordost/streetcomplete/osm/Shop.kt#L6 and https://github.com/mnalis/StreetComplete-taginfo-categorize for how StreetComplete deals with it - by maintaining list of tags safe to remove (that is from time to time manually updated...)
Note that it is not always better. |
@matkoniecz probably would be helpful to add this to https://wiki.openstreetmap.org/wiki/Keep_the_history? |
Maybe? New section "For developers of editing software" ? (I am not planning to add it myself, but wiki is editable by anyone) |
If a user selects this option while editing a biz, this app completely deletes node associated with that biz. This is a wrong approach since that not only deletes the address info associated with that location, but it also deletes the changeset history associated with that object/address.
A more appropriate approach should be to use lifecycle prefixes as documented in https://wiki.openstreetmap.org/wiki/Lifecycle_prefix
Or at the very least delete biz-specific tags, but leave the address info intact.
The text was updated successfully, but these errors were encountered: