Provide UA test vectors for the first 3 valid diversifier indices for each account #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacu
approved these changes
Sep 15, 2022
|
CI is failing :/ |
nuttycom
force-pushed
the
diversified_ua_sequences
branch
2 times, most recently
from
920a0b7
to
9000e02
Compare
nuttycom
force-pushed
the
diversified_ua_sequences
branch
from
9000e02
to
73ced0f
Compare
str4d
approved these changes
Sep 23, 2022
Comment on lines
+27
to
+28
| - name: Install gnome-keyring | ||
| run: sudo apt-get install gnome-keyring |
There was a problem hiding this comment.
One of the python dependencies refuses to build without it; that was the previous build failure.
nuttycom
added a commit
to nuttycom/librustzcash
that referenced
this pull request
Oct 8, 2022
This updates unified address test vectors after zcash/zcash-test-vectors#89 to check addresses across multiple diversifier indices, and also removes the superfluous binary encoding of UA strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.