Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offer security-hardening and tests thereof to upstream #1071

Open
zookozcash opened this issue Jul 7, 2016 · 3 comments
Open

offer security-hardening and tests thereof to upstream #1071

zookozcash opened this issue Jul 7, 2016 · 3 comments
Assignees
@arcalinea
Labels
C-upstream-port Category: Changes that are ported from the Bitcoin Core codebase. I-regression This is a regression, i.e. something that previously worked but now does not due to a change we made I-SECURITY Problems and improvements related to security. special to Zooko Zcash codebase
Projects
Security and Stability

Comments

@zookozcash
Copy link

re: #915

https://botbot.me/freenode/bitcoin-core-dev/2016-07-07/?msg=69269952&page=2

… and also learn from upstream about such things as make check-security. ☺
@zookozcash zookozcash added I-SECURITY Problems and improvements related to security. Zcash codebase C-upstream-port Category: Changes that are ported from the Bitcoin Core codebase. I-regression This is a regression, i.e. something that previously worked but now does not due to a change we made special to Zooko labels Jul 7, 2016
@zookozcash zookozcash mentioned this issue Jul 7, 2016
Closed
@defuse
Copy link
Contributor

defuse commented Jul 21, 2016

We're probably going to end up with a hybrid of upstream's approach and the one I started with, which probably isn't ideal for upstream. Ideally, we'd rewrite all the checksec.sh functionality (written in bash) in python and add it to test-security.py. But I think for this ticket it's sufficient to offer a pull request offering what we did, even if it isn't ideal.

@defuse
Copy link
Contributor

defuse commented Aug 17, 2016

We want to contribute the relevant parts of #1064 and #1267.

@zookozcash
Copy link
Author

@defuse: are you going to be able to finish this before you leave us? (😢) Maybe we should hand it off to Jay or someone.

@daira daira added this to the 1.0.1 stabilization milestone Sep 30, 2016
@str4d str4d added this to Work Queue in Security and Stability Apr 25, 2017
@nathan-at-least nathan-at-least removed this from the 1.0.[Soon] stabilization milestone May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arcalinea arcalinea

Labels
C-upstream-port Category: Changes that are ported from the Bitcoin Core codebase. I-regression This is a regression, i.e. something that previously worked but now does not due to a change we made I-SECURITY Problems and improvements related to security. special to Zooko Zcash codebase
Projects
No open projects
Security and Stability
  
Work Queue
Milestone
No milestone
Development

No branches or pull requests
5 participants
@daira @defuse @nathan-at-least @arcalinea @zookozcash