Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coverage reporting. #1235

Closed
nathan-at-least opened this issue Aug 11, 2016 · 3 comments
Closed

Fix coverage reporting. #1235

nathan-at-least opened this issue Aug 11, 2016 · 3 comments
Assignees
@defuse @nathan-at-least
Labels
A-CI Area: Continuous Integration A-testing Area: Tests and testing infrastructure
Milestone
z9 Release - RPC,...

Comments

@nathan-at-least
Copy link
Contributor

nathan-at-least commented Aug 11, 2016 •
edited

It looks like the hardening PR #1064 broke coverage reporting. See the bottom of the build.sh log in this build for the initial symptom.

I suspect it's related to passing both --enable-lcov and --enable-hardning to ./configure.

Note: This is an example of a PR that will not pass our new merge-quality criteria, since those now depend on checking coverage.
@nathan-at-least nathan-at-least added A-testing Area: Tests and testing infrastructure A-CI Area: Continuous Integration labels Aug 11, 2016
@nathan-at-least nathan-at-least self-assigned this Aug 11, 2016
@nathan-at-least
Copy link
Contributor Author

Status: I modified build.sh to not pass --enable-hardening if --enable-lcov is passed, but it still fails to build with the same symptom. This confuses me because our main zcash builder on buildbot succeeds. Why?

@defuse defuse self-assigned this Aug 11, 2016
@defuse
Copy link
Contributor

defuse commented Aug 11, 2016

Looks like this is happening because I changed configure.ac to fail when AX_CHECK_LINK_FLAG failed. So passing --enable-lcov is causing the linker to not accept -pie for some reason.

@defuse
Copy link
Contributor

defuse commented Aug 11, 2016

Not passing --enable-hardening didn't fix the issue because it is the default. To turn it off you have to pass --disable-hardening.

@defuse defuse mentioned this issue Aug 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@defuse defuse

@nathan-at-least nathan-at-least

Labels
A-CI Area: Continuous Integration A-testing Area: Tests and testing infrastructure
Projects
None yet
Milestone
z9 Release - RPC, Testing improvements
Development

No branches or pull requests
2 participants
@defuse @nathan-at-least