Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bashisms from build scripts #2677

Closed
daira opened this issue Oct 21, 2017 · 3 comments · Fixed by #2939
Closed

Remove bashisms from build scripts #2677

daira opened this issue Oct 21, 2017 · 3 comments · Fixed by #2939
Assignees
@daira
Labels
E-good-first-issue Effort: Suitable for someone new to the codebase. M-has-pr To-be-removed (GitHub has linked:pr filter) portability
Projects
Portability Arborist Team

Comments

@daira
Copy link
Contributor

daira commented Oct 21, 2017

This will fix #2676.
@daira daira self-assigned this Oct 21, 2017
@daira daira added this to Work Queue in Portability Nov 11, 2017
@daira daira mentioned this issue Nov 11, 2017
Closed
@daira daira added the E-good-first-issue Effort: Suitable for someone new to the codebase. label Nov 22, 2017
@syd0
Copy link
Contributor

syd0 commented Nov 23, 2017

Hi @daira - I'm unable to reproduce this issue. I'm running on Debian which has dash as it's default /bin/sh. Were you able to reproduce the issue? Is this an Ubuntu-specific thing?

@fishouttah20
Copy link

I was just able to reproduce #2676 on my bash for windows (ubuntu on win10) with similar errors to the previous user:
/bin/sh: 1: Syntax error: "(" unexpected
funcs.mk:242: recipe for target

@radix42
Copy link
Contributor

radix42 commented Dec 1, 2017

i have fixed the funcs.mk issue in my downstream ports to other platforms, but I can't recall off the top of my head which commits its in, as that was about a year ago

@plutoforever plutoforever mentioned this issue Feb 9, 2018
Merged
@str4d str4d added the M-has-pr To-be-removed (GitHub has linked:pr filter) label Aug 5, 2018
@mms710 mms710 added this to Blocked in Arborist Team Dec 14, 2018
@zkbot zkbot closed this as completed in 51ca3b9 Apr 1, 2021
Arborist Team automation moved this from Blocked to Complete Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daira daira

Labels
E-good-first-issue Effort: Suitable for someone new to the codebase. M-has-pr To-be-removed (GitHub has linked:pr filter) portability
Projects
Arborist Team
  
Complete
Portability
  
Work Queue
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed bashisms from build scripts plutoforever/zcash
5 participants
@daira @str4d @radix42 @fishouttah20 @syd0