Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write another benchmark to measure worst-case block verification latency #3790

Open
daira opened this issue Jan 17, 2019 · 1 comment
Open

Write another benchmark to measure worst-case block verification latency #3790

daira opened this issue Jan 17, 2019 · 1 comment
Labels
A-benchmarks Area: Benchmarks I-dos Problems and improvements with respect to Denial-of-Service. I-performance Problems and improvements with respect to performance NU1-sapling Network upgrade: Sapling-specific tasks NU2-blossom-adjacent Issues that aren't directly part of the Blossom upgrade, but that we want to complete alongside it.
Milestone
v2.0.4

Comments

@daira
Copy link
Contributor

daira commented Jan 17, 2019

This would be for a 2 MB block full of Sapling spends. (You have to verify both a RedDSA signature and a Groth16 proof for each spend, and the spend descriptions are smaller than output descriptions.)

I think it doesn't matter very much whether these are in a single transaction or multiple transactions. The former is slightly denser in terms of verification work per byte.
@daira daira added I-performance Problems and improvements with respect to performance I-dos Problems and improvements with respect to Denial-of-Service. NU1-sapling Network upgrade: Sapling-specific tasks A-benchmarks Area: Benchmarks NU2-blossom-adjacent Issues that aren't directly part of the Blossom upgrade, but that we want to complete alongside it. labels Jan 17, 2019
@daira daira added this to Needs Prioritization in Protocol Team via automation Jan 17, 2019
@daira daira added this to Needs Prioritization in Arborist Team via automation Jan 17, 2019
@daira daira mentioned this issue Jan 17, 2019
Closed
@mms710 mms710 moved this from Needs Prioritization to Blocked in Arborist Team Jan 17, 2019
@mms710 mms710 moved this from Blocked to Sprint Backlog in Arborist Team Jan 17, 2019
@bitcartel bitcartel mentioned this issue Jan 17, 2019
Closed
@str4d str4d added this to the v2.0.4 milestone Mar 6, 2019
@str4d
Copy link
Contributor

str4d commented Mar 6, 2019

I implemented this in https://github.com/str4d/zcash/tree/worst-case-benchmarks. Simulation results are posted in #3690 (comment) and subsequent comments.

@str4d str4d removed this from Needs Prioritization in Protocol Team Mar 6, 2019
@mms710 mms710 moved this from Bugs/Security Issues/TechDebt Backlog to Protocol Backlog in Arborist Team Apr 16, 2019
@mms710 mms710 removed this from Protocol Backlog in Arborist Team May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-benchmarks Area: Benchmarks I-dos Problems and improvements with respect to Denial-of-Service. I-performance Problems and improvements with respect to performance NU1-sapling Network upgrade: Sapling-specific tasks NU2-blossom-adjacent Issues that aren't directly part of the Blossom upgrade, but that we want to complete alongside it.
Projects
None yet
Milestone
v2.0.4
Development

No branches or pull requests
2 participants
@daira @str4d