Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization missing, particularly for quantity strings and plurals #4043

Open
gmale opened this issue Jun 10, 2019 · 3 comments
Open

Localization missing, particularly for quantity strings and plurals #4043

gmale opened this issue Jun 10, 2019 · 3 comments

Comments

@gmale
Copy link

gmale commented Jun 10, 2019

Describe the issue

Zcashd does not appear to handle localization of strings. This is particularly noticeable for quantity strings.

Can you reliably reproduce the issue?

Yes

If so, please list the steps to reproduce below:

  1. Use zcashd and observe strings with quantities

Expected behaviour

Strings should adhere to proper quantities for the given Locale, correctly handling zero, one and many.

Rather than piecemeal, one-off fixes, this should probably be addressed systemically with a library like fluent-rs which implements project fluent. An added benefit of doing this well is Zcashd could eventually support multiple languages. Proper quantities would be the first step.

Actual behaviour + errors

Quantity strings and plurals are not correct. Such as:

You have mined 1 blocks!
You have validated 1 transactions!
Since starting this node 1 minutes, 1 seconds ago

The version of Zcash you were using:

v2.0.2

Machine specs:

Not machine-specific

@ravibhojwani
Copy link

soon my nodes will be contributing

@ravibhojwani
Copy link

IP will change - is static ip best??

@daira
Copy link
Contributor

daira commented Jun 16, 2019

Hi @ravibhojwani . Your comments aren't on topic for this ticket; you might get more useful responses from the #zcash or #user-support channels on https://chat.zcashcommunity.com .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants