make -C ./depends download fails on Debian stable due to a darwin artifact.

[nathan-at-least]

Describe the issue

When I run make -C ./depends download it fails on Debian 9.9 Stretch and also in a reproducible Dockerfile FROM debian:stable.

Can you reliably reproduce the issue?

Yes. This Dockerfile reproduces it when running docker build .:

FROM debian:stable

RUN export DEBIAN_FRONTEND="noninteractive" && \
    apt-get -y update && \
    apt-get -y upgrade && \
    apt-get -y dist-upgrade && \
    apt-get -y autoremove && \
    apt-get -y install \
        build-essential \
        curl \
        git

RUN git clone 'https://github.com/zcash/zcash'
WORKDIR /zcash

RUN make -C ./depends download

If so, please list the steps to reproduce below:

Approach 1 - On a Debian stretch or buster system:

1. git clone 'https://github.com/zcash/zcash'
2. cd ./zcash
3. make -C ./depends download

Approach 2 - On a system with Docker:

1. Place the Dockerfile quoted above into a file named Dockerfile in an empty directory.
2. In that directory run docker build.

Expected behaviour

I expect tarballs for all the dependencies with correct hashes to appear in ./depends/sources. The documentation in ./depends/README.md says:

Additional targets:

    download: run 'make download' to fetch all sources without building them
    download-osx: run 'make download-osx' to fetch all sources needed for osx builds
    download-win: run 'make download-win' to fetch all sources needed for win builds
    download-linux: run 'make download-linux' to fetch all sources needed for linux builds

I assumed the general download would just work on any platform.

Actual behaviour + errors

Early on in the output I see this error:

/bin/sh: 1: test: rust-std-1.32.0-x86_64-apple-darwin11.tar.gz: unexpected operator

The output ends with:

Fetching rust...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 
make[1]: Leaving directory '/zcash/depends'
make[1]: *** [funcs.mk:260: /zcash/depends/sources/download-stamps/.stamp_fetched-rust-rust-std-1.32.0-x86_64-apple-darwin11.tar.gz.hash] Error 22                                                                                                                        
make: *** [Makefile:149: download-osx] Error 2
make: Leaving directory '/zcash/depends'
The command '/bin/sh -c make -C ./depends download' returned a non-zero code: 2

Notice the HTTP 404s. I'm not sure what that's about, but maybe because of a makefile/shell bug a malformed URL is requested?

The version of Zcash you were using:

This is from a git clone today:

65b44ab59 2019-08-14 16:34:02 -0700 - Auto merge of #4098 - zebambam:optimize_parameter_downloads, r=str4d <sysadmin@z.cash> (HEAD -> master, origin/master, origin/auto, origin/HEAD)

Run zcashd --version to find out

Machine specs:

Debian stretch or Docker's debian:stable

Any extra information that might be useful in the debugging process.

none

Do you have a backup of ~/.zcash directory and/or take a VM snapshot?

not applicable.

Potentially related:

• Building zcash on airgapped machines is difficult #1663