Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for overflow of the wallet account counter #5487

Closed
str4d opened this issue Jan 19, 2022 · 1 comment · Fixed by #5849
Closed

Check for overflow of the wallet account counter #5487

str4d opened this issue Jan 19, 2022 · 1 comment · Fixed by #5849
Labels
A-wallet Area: Wallet NU5 Network upgrade: NU5-specific tasks S-committed Status: Planned work in a sprint
Milestone
Release 4.7.0

Comments

@str4d
Copy link
Contributor

str4d commented Jan 19, 2022

This overflow is actually reachable because it's only at 231.

See the TODO I added here: #5475 (comment)
@str4d str4d added A-wallet Area: Wallet NU5 Network upgrade: NU5-specific tasks labels Jan 19, 2022
@str4d str4d mentioned this issue Jan 19, 2022
Merged
@r3ld3v
Copy link
Contributor

r3ld3v commented Mar 9, 2022

@str4d Wouldn't the max here be 2^32? accountCounter is a uint32_t . Overflow here would be a wrap back to zero IIUC.

@r3ld3v r3ld3v added this to the Release 5.0.0 milestone Mar 29, 2022
@r3ld3v r3ld3v added S-committed Status: Planned work in a sprint and removed S-committed Status: Planned work in a sprint labels Mar 29, 2022
@therealyingtong therealyingtong mentioned this issue Apr 8, 2022
Merged
@str4d str4d modified the milestones: Release 5.0.0, Release 4.7.0 Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-wallet Area: Wallet NU5 Network upgrade: NU5-specific tasks S-committed Status: Planned work in a sprint
Projects
None yet
Milestone
Release 4.7.0
Development

Successfully merging a pull request may close this issue.

Check for overflow in IncrementAccountCounter(). therealyingtong/zcash
2 participants
@str4d @r3ld3v