Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up null pointer handling in Rust FFI #5583

Open
nuttycom opened this issue Feb 23, 2022 · 1 comment
Open

Clean up null pointer handling in Rust FFI #5583

nuttycom opened this issue Feb 23, 2022 · 1 comment
Labels
A-rust-ffi Area: The Rust FFI in the librustzcash library.
Milestone
Release 5.10.0

Comments

@nuttycom
Copy link
Contributor

In a number of places in the Rust FFI, we do not adequately check for null pointers, e.g. #5569 (comment)

This style of use is common in rustzcash.rs and we should clean up all of them at once.
@nuttycom nuttycom mentioned this issue Feb 23, 2022
Merged
@r3ld3v r3ld3v added this to the Release 5.2.0 milestone Apr 12, 2022
@daira daira modified the milestones: Release 5.3.0, Release 5.4.0 Sep 19, 2022
@nuttycom nuttycom modified the milestones: Release 5.4.0, Release 5.5.0 Nov 21, 2022
@str4d
Copy link
Contributor

str4d commented Jan 5, 2023

I made this issue block #5716 because migrating fully to cxx will necessitate addressing this issue.

@str4d str4d added the A-rust-ffi Area: The Rust FFI in the librustzcash library. label Jan 5, 2023
@nuttycom nuttycom modified the milestones: Release 5.5.0, Release 5.6.0 Jan 30, 2023
@nuttycom nuttycom modified the milestones: Release 5.6.0, Release 5.7.0 Mar 23, 2023
@str4d str4d modified the milestones: Release 5.7.0, Release 5.8.0 Sep 21, 2023
@str4d str4d modified the milestones: Release 5.8.0, Post 5.8.0 Dec 21, 2023
@daira daira modified the milestones: Post 5.8.0, Release 5.9.0 Jan 16, 2024
@daira daira modified the milestones: Release 5.9.0, Release 5.10.0 Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rust-ffi Area: The Rust FFI in the librustzcash library.
Projects
None yet
Milestone
Release 5.10.0
Development

No branches or pull requests
4 participants
@nuttycom @daira @str4d @r3ld3v