Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: document error codes for getblock #5758

Open
teor2345 opened this issue Mar 28, 2022 · 0 comments
Open

RPC: document error codes for getblock #5758

teor2345 opened this issue Mar 28, 2022 · 0 comments
Labels

Comments

@teor2345
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The getblock documentation does not document the error code used when a block is not available.

But lightwalletd checks for the exact error code -8:
https://github.com/adityapk00/lightwalletd/blob/c1bab818a683e4de69cd952317000f9bb2932274/common/common.go#L251-L254

Describe the solution you'd like

Document the error code returned when there is no block with that height or hash.

Alternatives you've considered

Maybe lightwalletd could document this requirement, or provide a better error message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant