Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display pass ratio in RPC test summary #6492

Merged
merged 1 commit into from May 3, 2023
Merged

Display pass ratio in RPC test summary #6492

merged 1 commit into from May 3, 2023

Conversation

sellout
Copy link
Contributor

@sellout sellout commented Mar 16, 2023

When everything passes, still show “True”, but when there are failures, show passed/total.

@sellout sellout added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. safe-to-build Used to send PR to prod CI environment labels Mar 30, 2023
@sellout sellout marked this pull request as ready for review March 30, 2023 20:34
@ECC-CI ECC-CI removed the safe-to-build Used to send PR to prod CI environment label Mar 30, 2023
@nuttycom nuttycom marked this pull request as draft April 4, 2023 20:39
@nuttycom nuttycom removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2023
@sellout
Display pass ratio in RPC test summary
2d53ce1 
When everything passes, still show “True”, but when there are failures, show passed/total.
@sellout sellout added the safe-to-build Used to send PR to prod CI environment label Apr 27, 2023
@sellout sellout marked this pull request as ready for review April 27, 2023 19:27
@sellout sellout added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2023
@ECC-CI ECC-CI removed the safe-to-build Used to send PR to prod CI environment label Apr 27, 2023
nuttycom
nuttycom approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom nuttycom merged commit 548fa74 into zcash:master May 3, 2023
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuttycom nuttycom nuttycom approved these changes

@daira daira Awaiting requested review from daira

@str4d str4d Awaiting requested review from str4d

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sellout @nuttycom @ECC-CI