Support the rkt/minikube-iso #140
Conversation
zchee
force-pushed
the
minikube-iso_kexec
branch
from
3cd48ca
to
efc4a99
Compare
|
/cc @dlorenc @r2d4 /cc @s-urbaniak Is there no problem this fix? |
|
I will release |
zchee
force-pushed
the
minikube-iso_kexec
branch
2 times, most recently
from
d0a465c
to
7d55ee7
Compare
|
@zchee LGTM! I'll prepare a PR against minikube to configure the driver correctly with the minikube-iso image. |
|
@s-urbaniak Thanks for test :) |
|
@zchee I would prepare a PR against minikube like you did in zchee/minikube@b646163 :-) Although looking at your change I am wondering how to "autodetect" whether it is a minikube-iso or boot2docker, maybe by looking at the |
|
@s-urbaniak Ah, yeah. It would be better to implement the processing. Which is implement parse of iso? xhyve side? minikube? Edit: Do you think which one is better? |
|
Hmm ... I just tried out this PR, and I get this error: PS: The master branch works. |
- qcow2: remove go generate 'mv .o .syso', use '#cgo LDFLAGS: -lfoo.o'
- kexec: temporary fix ramdisk_start to twice size
- it would be incorrect, but can boot large size kernel.
- Tested tinycore, debian testing, ubuntu yakkety, minikube-iso and
boot2docker
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
- Support modifiable kernel executable and initrd image filename, because of different filename by distro, tools. such as buildroot Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
zchee
force-pushed
the
minikube-iso_kexec
branch
from
7d55ee7
to
b140c00
Compare
|
@s-urbaniak Ah, really...? work fine this pull request :( Edit: pre-compile binary and test iso http://get.zchee.io/bin/docker-machine-driver-xhyve
shasum -a 256 ./bin/docker-machine-driver-xhyve
44cb25be703e416202ed24189c4b26fbc37342de489bbf53fc99140ae9b14acc ./bin/docker-machine-driver-xhyvehttp://get.zchee.io/bin/minikube shasum -a 256 minikube
869880dbc61074fc49d018549274e877cb117698598f673338e5d0e9a32d5114 minikubehttp://s3.zchee.io/iso/minikube-virtblk.iso shasum -a 256 minikube-virtblk.iso
93301b7231f94bc4b1662ac486dd09e01c3b34b45947346f759370300861aeef minikube-virtblk.iso |
|
/cc @dlorenc @r2d4 @s-urbaniak |
- kexec.c commit message
- Use the initrd_addr_max value from the kernel header if the
kernel version is 2.03 or newer. Use hardcoded(0x37ffffff) value
if older.
- Compare the initrd_max and memory.size, and re-assign if
initrd_max is larger.
- Add ALIGNDOWN for ramdisk_start, uses prevent to go past the
address limit.
- Based on qemu/hw/i386/pc.c
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
zchee
force-pushed
the
minikube-iso_kexec
branch
from
d451469
to
6e75aa4
Compare
|
@zchee I had some trouble creating the vm. I'm get the same error as s-urbaniak above
|
|
@r2d4 Hmm... is this binary build from source with this PR? |
|
@s-urbaniak @r2d4 Ah, repro on latest Edit: |
|
@dlorenc @r2d4 @s-urbaniak |
|
@zchee since I wasn't able to get the xhyve driver running locally with this PR, I was not able to progress on the minikube side. When I'll be back in the office next week, I can retry using this PR, and the latest minikube on master. |
|
Hey, I'm trying to build this locally and I'm getting this error: duplicate symbol _caml_tuplify5 in:
mirage_block_ocaml.syso
vendor/github.com/zchee/libhyperkit/mirage_block_ocaml.o
duplicate symbol _caml_tuplify7 in:
mirage_block_ocaml.syso
vendor/github.com/zchee/libhyperkit/mirage_block_ocaml.o
duplicate symbol _caml_tuplify8 in:
mirage_block_ocaml.syso
vendor/github.com/zchee/libhyperkit/mirage_block_ocaml.o
ld: 14678 duplicate symbols for architecture x86_64Any ideas? |
|
@dlorenc It seems to exists |
|
Ah nice, make clean wasn't working but I recloned the repository and got it to build. $ minikube version
minikube version: v0.12.1
$ GO_BUILD_TAGS='lib9p qcow2' make V=1 installbut I'm now getting the same error as @r2d4. |
|
I think I found the issue. I'll send a few PRs in a bit. |
|
@dlorenc Ah, I was talking on the slack with @r2d4, This pull request needs this change on minikube side. If call xhyve-driver by minikube, will However, this problem might be solved with adding initialize method.
Sorry, I still don't understand minikube internal. |
Maybe in here: https://github.com/kubernetes/minikube/blob/master/pkg/minikube/cluster/cluster_darwin.go#L63 ? |
|
@dlorenc Ah, sorry. Maybe I misunderstood and mistaken... |
|
Sure! Let me know if I can help. |
|
@dlorenc Thanks. BTW, I want to local test use original minikube-alpha(?) iso file. |
|
Not sure what you mean. You can grab the rkt/systemd ISO at the URL in the doc here: https://github.com/kubernetes/minikube/blob/master/README.md#using-rkt-container-engine |
|
@dlorenc It means http://storage.googleapis.com/minikube/iso/buildroot/minikube-v0.0.5.iso ? In other words, When you plan to minikube support of qcow2 disk image? |
|
Indeed the virtio config is not present in the 0.0.5 release yet, as coreos/minikube-iso#28 was merged after the release. dlorenc let me know if I can help out with releasing a 0.0.6, which would include the above kernel config. |
|
@r2d4 just released 0.6 yesterday. |
|
@dlorenc thanks for release 0.6. |
Defer the unmount.
Auto-detect whether the kernel is bzImage or vmlinuz.
|
@dlorenc Merged your two PR. thanks. |
|
Yeah, doing some final sanity testing now :) @r2d4 could you try this out today too? |
|
@dlorenc Got it. I'll re-test with |
|
Nice! Everything works for me. Merge whenever :) |
|
Nah, it should be safe to merge now. |
|
Merged. Thanks! |
|
It works on my machine also 👍 |
|
@dlorenc @r2d4 @s-urbaniak |
|
@zchee 👍 thanks a lot!!! |
Support the rkt/minikube-iso.
mv .o .syso, use#cgo LDFLAGS: -lfoo.o