Skip to content

Commit

Permalink
Fix scripts to build the desktop app. Fix windows icons
Browse files Browse the repository at this point in the history
  • Loading branch information
cmgustavo committed Apr 30, 2018
1 parent 89c5933 commit e697d1b
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions app-template/build-macos.sh
Expand Up @@ -73,15 +73,15 @@ if [ $SHOULD_SIGN ]
then
echo "Signing ${APP_NAME} DMG"

export IDENTITY="3rd Party Mac Developer Application: BitPay, Inc. (884JRH5R93)"
export IDENTITY="iPhone Distribution: BitPay, Inc. (884JRH5R93)"

# not need for 'out of app store' distribution (?)
# export PARENT_PLIST=parent.plist
# export CHILD_PLIST=child.plist
export APP_PATH=${STAGING_DIR}/${APP_NAME}.app

codesign --deep -s "${IDENTITY}" $APP_PATH"/Contents/Versions/52.0.2743.82/nwjs Helper.app" && echo "Sign 1"
codesign --deep -s "${IDENTITY}" $APP_PATH"/Contents/Versions/52.0.2743.82/nwjs Framework.framework/Resources/app_mode_loader.app" && echo "Sign 2"
codesign --deep -s "${IDENTITY}" $APP_PATH"/Contents/Versions/55.0.2883.87/nwjs Helper.app" && echo "Sign 1"
codesign --deep -s "${IDENTITY}" $APP_PATH"/Contents/Versions/55.0.2883.87/nwjs Framework.framework/Resources/app_mode_loader.app" && echo "Sign 2"
codesign --deep -s "${IDENTITY}" $APP_PATH && echo "Sign 3"
echo "Signing Done"

Expand Down
2 changes: 1 addition & 1 deletion app-template/setup-win.iss
Expand Up @@ -35,7 +35,7 @@ Name: "desktopicon"; Description: "{cm:CreateDesktopIcon}"; GroupDescription: "{
[Files]
Source: "*USERVISIBLENAME*\win64\*USERVISIBLENAME*.exe"; DestDir: "{app}"; Flags: ignoreversion
Source: "*USERVISIBLENAME*\win64\*"; DestDir: "{app}"; Flags: ignoreversion recursesubdirs createallsubdirs
Source: "../www/img/app/logo.ico"; DestDir: "{app}"; DestName: "icon.ico"; Flags: ignoreversion
Source: "../www/assets/img/app/logo.ico"; DestDir: "{app}"; DestName: "icon.ico"; Flags: ignoreversion
; NOTE: Don't use "Flags: ignoreversion" on any shared system files

[Icons]
Expand Down
Binary file modified resources/bitpay/windows/icon.ico
Binary file not shown.
Binary file modified resources/copay/windows/icon.ico
Binary file not shown.

0 comments on commit e697d1b

Please sign in to comment.