Preventing surges in sigma #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 7, 2019 20:04
added 2 commits
June 17, 2019 09:31
|
Ready to review. The test failure caused by the HD mint test failure. |
riordant
suggested changes
Jun 20, 2019
psolstice
requested changes
Jun 20, 2019
| @@ -0,0 +1,59 @@ | |||
| #ifndef HASH_FUNCTIONS_H__ | |||
| #define HASH_FUNCTIONS_H__ | |||
|
|
|||
There was a problem hiding this comment.
When renaming a file you need to change the constants at the top
| void CSigmaState::Containers::AddMint(sigma::PublicCoin const & pubCoin, CMintedCoinInfo const & coinInfo) { | ||
| mintedPubCoins.insert(std::make_pair(pubCoin, coinInfo)); | ||
| mintMetaInfo[coinInfo.coinGroupId][coinInfo.denomination] += 1; | ||
| CheckSurgeCondition(coinInfo.coinGroupId, coinInfo.denomination); |
There was a problem hiding this comment.
How adding a mint can create a surge condition? Same for removing a spend
levonpetrosyan93
previously approved these changes
Jun 21, 2019
riordant
previously approved these changes
Jun 21, 2019
psolstice
previously approved these changes
Jun 21, 2019
a-bezrukov
dismissed stale reviews from psolstice, riordant, and levonpetrosyan93
via
b76ec92
levonpetrosyan93
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.