You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on Issue #188 / PR #195 I noticed that across the code base there are a number of places that use ValueErrors that should be TypeErrors. For example, in grama/comp_building.py line 59 & 60 read:
elif out is None:
raise ValueError("`out` must be list or int")
This is an error for an invalid type (give out argument is None) but it throws a ValueError. This doesn't match Python naming conventions. This happens many places across the code base and this should be updated for user readability and matching the syntax of other packages. I went ahead and updated the eval functions, but the rest of the code base still needs to be updated.
This should be a simple fix of just updating the error type, and updating the associated unittests.
The text was updated successfully, but these errors were encountered:
Marked this as a good first issue. Recommend especially for any new software develop research assistants, as this task will require going through a lot of code, but not require a super dense understanding of every function.
While working on Issue #188 / PR #195 I noticed that across the code base there are a number of places that use ValueErrors that should be TypeErrors. For example, in grama/comp_building.py line 59 & 60 read:
This is an error for an invalid type (give out argument is None) but it throws a ValueError. This doesn't match Python naming conventions. This happens many places across the code base and this should be updated for user readability and matching the syntax of other packages. I went ahead and updated the eval functions, but the rest of the code base still needs to be updated.
This should be a simple fix of just updating the error type, and updating the associated unittests.
The text was updated successfully, but these errors were encountered: