Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scalars] Remove Scalar from return types of functions. #116

Closed
zdevito opened this issue Oct 20, 2017 · 1 comment
Closed

[Scalars] Remove Scalar from return types of functions. #116

zdevito opened this issue Oct 20, 2017 · 1 comment

Comments

@zdevito
Copy link
Owner

zdevito commented Oct 20, 2017

We want to unite functions like Scalar sum(Tensor & tensor); with the other variants of sum. To do this, we must return a Tensor in these cases.

This can be done in two parts:
[ ] Force the creation of Tensors from Scalar objects now.
[ ] Change TH so that in cases where scalars exist on the GPU, we don't both to copy back and just create a Tensor directly.

Note: the first part depends on changing the behavior of how 0-dim tensors in all places where they are valid.

@killeent
Copy link
Collaborator

Per @gchanan this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants