Fix stdio.h include problem #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottslaughter
approved these changes
Oct 21, 2019
|
Merged, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #401 by compensating for what is probably an LLVM bug in
copyAttributesFromwhich doesn't actually copy over thecomdatattributes. Either that, or LLVM doesn't considercomdata traditional attribute. The actual fix here is a single line of code:newfn->setComdat(fn->getComdat());. Everything else is either just to improve MSVC compatibility, or is the stdio workaround being removed from the tests.A separate bug may need to be filed upstream to LLVM.