Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join forces with zsh-users #8

Open
xeruf opened this issue Nov 11, 2021 · 9 comments
Open

Join forces with zsh-users #8

xeruf opened this issue Nov 11, 2021 · 9 comments

Comments

@xeruf
Copy link
Contributor

xeruf commented Nov 11, 2021

Since this organisation was born out of necessity rather than purpose (https://teddit.net/r/zsh/comments/qinb6j/httpsgithubcomzdharma_has_suddenly_disappeared_i/hil4oww/)
how about incorporating the repos into @zsh-users for better maintenance (@nicoulaj)?

@CleytonRR
Copy link

Good idea

@alichtman
Copy link
Member

This sounds like a good idea to me. I'd be interested in hearing thoughts from @nicoulaj and @pschmitt.

@pschmitt
Copy link
Member

pschmitt commented Nov 16, 2021

Not totally against the idea of doing so since I feel less comfortable maintaining f-sy-h than let's say zinit, but:

I don't want to point people to another repo that gets archived a few days down the line.

@xeruf
Copy link
Contributor Author

xeruf commented Nov 16, 2021

If you have a project you want to host here, ping @nicoulaj / #zsh-users on Matrix.

That's why I added the ping.
Maybe zsh-syntax-highlighting can even be updated with the innovations from fast-syntax-highlighting and they can be unified again :)

@CleytonRR
Copy link

Not totally against the idea of doing so since I feel less comfortable maintaining f-sy-h than let's say zinit, but:

* is @zsh-users even interested in hosting f-sy-h? It'd kinda be awkward since https://github.com/zsh-users/zsh-syntax-highlighting is a thing

I don't want to point people to another repo that gets archived a few days down the line.

I prefer the fast-syntax-highlighting, if this repository will added in zsh-users, would be more easy to find it, and more people could contribute with it.
congrats for this works, guys 🚀 !!!

@AnimiVulpis
Copy link

Did anyone ping him as described in the official @zsh-users description string?

Zsh community projects (not directly affiliated with the zsh project). If you have a project you want to host here, ping @nicoulaj / #zsh-users on Matrix.

I never used Matrix 🤷 so I didn't

@alichtman
Copy link
Member

I looked for the channel and couldn't find it. Only found #zsh

@nicoulaj
Copy link

nicoulaj commented Nov 18, 2021

Hi guys,

Why not as long as there is a team of trusted people committed to maintaining it. However, I want to make it clear that psprint will not be given any committer access in zsh-users given his past actions, unless other admins disagree with me. The zsh-users org is very much based on trust and we don't want to risk having someone delete the repositories or push malicious stuff.

Also, this project started as a hostile fork of zsh-syntax-highlighting if I am not mistaken, and I find it a bit sad that we now have two competing syntax highlighting plugins... Maybe it would be better to try merging back the improvements made here into zsh-syntax-highlighting ?

I am not actively contributing to zsh-syntax-highlighting anymore, @danielshahaf @phy1729 WDYT ?

edit: btw, zsh-syntax-highlighting contributors are on IRC: libera.chat / #zsh-syntax-highlighting

@phy1729
Copy link

phy1729 commented Nov 19, 2021

Looks like Sebastian has explicitly allowed z-sy-h to incorporate f-sy-h code zsh-users/zsh-syntax-highlighting#434 (comment) .

Just looking at the directory structure, it seems there's been a significant refactoring since the z-sy-h fork. There are no separate highlighters, there are now chroma, and the tests seem to be largely missing. I certainly have no opposition to incorporating f-sy-h features and bug fixes (indeed there's issue 434 for this very thing); however, as a simple diff between the two projects isn't feasable, it would be helpful for users to identify what features and bug fixes f-sy-h has developed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants