-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Join forces with zsh-users #8
Comments
Good idea |
Not totally against the idea of doing so since I feel less comfortable maintaining f-sy-h than let's say zinit, but:
I don't want to point people to another repo that gets archived a few days down the line. |
That's why I added the ping. |
I prefer the fast-syntax-highlighting, if this repository will added in zsh-users, would be more easy to find it, and more people could contribute with it. |
Did anyone ping him as described in the official @zsh-users description string?
I never used Matrix 🤷 so I didn't |
I looked for the channel and couldn't find it. Only found #zsh |
Hi guys, Why not as long as there is a team of trusted people committed to maintaining it. However, I want to make it clear that psprint will not be given any committer access in zsh-users given his past actions, unless other admins disagree with me. The zsh-users org is very much based on trust and we don't want to risk having someone delete the repositories or push malicious stuff. Also, this project started as a hostile fork of zsh-syntax-highlighting if I am not mistaken, and I find it a bit sad that we now have two competing syntax highlighting plugins... Maybe it would be better to try merging back the improvements made here into zsh-syntax-highlighting ? I am not actively contributing to zsh-syntax-highlighting anymore, @danielshahaf @phy1729 WDYT ? edit: btw, zsh-syntax-highlighting contributors are on IRC: libera.chat / |
Looks like Sebastian has explicitly allowed z-sy-h to incorporate f-sy-h code zsh-users/zsh-syntax-highlighting#434 (comment) . Just looking at the directory structure, it seems there's been a significant refactoring since the z-sy-h fork. There are no separate highlighters, there are now chroma, and the tests seem to be largely missing. I certainly have no opposition to incorporating f-sy-h features and bug fixes (indeed there's issue 434 for this very thing); however, as a simple diff between the two projects isn't feasable, it would be helpful for users to identify what features and bug fixes f-sy-h has developed. |
Since this organisation was born out of necessity rather than purpose (https://teddit.net/r/zsh/comments/qinb6j/httpsgithubcomzdharma_has_suddenly_disappeared_i/hil4oww/)
how about incorporating the repos into @zsh-users for better maintenance (@nicoulaj)?
The text was updated successfully, but these errors were encountered: