Elixir syntax highlighting not working properly for doc attributes (and more)

[ryanwinchester]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

It appears as though things are mostly correct but the @doc, @moduledoc, and @typedoc are not being recognized as comments. They are being highlighted as normal module attributes and multiline strings, when really they should be comments.

Environment

Zed 0.66.1 – /Applications/Zed.app
macOS 13.1
architecture x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Zed:

VS Code:

GitHub:

link to same file as screenshots:

• https://github.com/mtrudel/bandit/blob/main/lib/bandit.ex

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue

No response

[ryanwinchester]

Another thing is that there are some special macros with double underscores being highlighted as ignored variables (single underscore prefix).

i.e.: __ENV__/0, __MODULE__/0, __DIR__/0, __STACKTRACE__/0, and __CALLER__/0
from https://hexdocs.pm/elixir/Kernel.SpecialForms.html

[ryanwinchester]

Apparently this file has all the goodies:

• Doc comments example: https://github.com/elixir-lang/tree-sitter-elixir/blob/b20eaa75565243c50be5e35e253d8beb58f45d56/queries/highlights.scm#L7-L21
• Special constants example: https://github.com/elixir-lang/tree-sitter-elixir/blob/b20eaa75565243c50be5e35e253d8beb58f45d56/queries/highlights.scm#L160-L164

Should help with the two issues I mentioned, and likely more.

(Shout-out to @jonatanklosko)

[JosephTLyons]

This should be fixed in v0.90.0.