Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serendipity #24

Closed
1 task done
covt opened this issue Feb 7, 2023 · 6 comments
Closed
1 task done

Serendipity #24

covt opened this issue Feb 7, 2023 · 6 comments
Assignees
Labels
theme A request to add a theme extension

Comments

@covt
Copy link

covt commented Feb 7, 2023

Check for existing issues

  • Completed

Describe the feature

Support for Serendipity family of themes, with the color palettes for each being provided here. https://serendipitytheme.com/serendipity-color-palette/

The theme family supports 3 versions:

Morning (Mid Light)
Sunset (Low Contrast Dark)
Midnight (Mid Contrast Dark)

Morning
image

Sunset
image

Midnight
image

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@iamnbutler
Copy link
Member

FYI I did start on a Serendipity port, however it looks like until we land theme overrides (which Mikayla is working on right now luckily!) it won't really look at all correct:

CleanShot - 2023-02-08 at 22 37 27@2x

I'll get it set up but wait until we ship overrides before we ship the theme family.

@iamnbutler iamnbutler self-assigned this Feb 9, 2023
@iamnbutler iamnbutler added the theme A request to add a theme extension label Feb 9, 2023
@iamnbutler
Copy link
Member

Most of the way there on this :) It's coming!

CleanShot 2023-02-26 at 22 41 54@2x

@iamnbutler
Copy link
Member

Closed in favor of https://github.com/zed-industries/community/discussions/1780

A extra little note on this one - Sorry for getting it partially done and cancelling it. We are hitting an upper limit of what we can reasonably compile locally since our current theme implementation generates 10k+ lines of json per theme. We are working on changing this system, and I'll make sure we get this in when we can!

@iamnbutler iamnbutler closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2023
@covt
Copy link
Author

covt commented Jul 20, 2023

No worries, I've been using Zed daily even without this. Excited to see the future theme implementation!

@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
@JosephTLyons JosephTLyons transferred this issue from zed-industries/zed Feb 15, 2024
@JosephTLyons
Copy link
Collaborator

Hello @covt, I've transferred your issue into the extensions repository and have reopened it.

@JosephTLyons JosephTLyons reopened this Feb 16, 2024
@JosephTLyons JosephTLyons changed the title Serendipity Theme Family Support Serendipity theme Feb 16, 2024
@JosephTLyons JosephTLyons changed the title Serendipity theme Serendipity Feb 26, 2024
@maxdeviant
Copy link
Member

A Serendipity extension is now available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme A request to add a theme extension
Projects
None yet
Development

No branches or pull requests

4 participants