Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zed crashes when click “Reveal in Finder” #5955

Closed
1 task done
TENX-S opened this issue Feb 24, 2023 · 1 comment
Closed
1 task done

Zed crashes when click “Reveal in Finder” #5955

TENX-S opened this issue Feb 24, 2023 · 1 comment
Labels
defect [core label] panic / crash [core label]

Comments

@TENX-S
Copy link
Contributor

TENX-S commented Feb 24, 2023

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

  1. Get a big rust project, delete its target folder (important!)
  2. Right-click a file and click “Reveal in Finder”

This issue is reproducible when rust-analyzer is indexing.

Screen.Recording.2023-02-24.at.13.45.25.mov

Environment

Zed: v0.74.2 (stable)
OS: macOS 13.2.1
Memory: 8 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

There was some of the same panic information in the log after I experienced this issue several times:

2023-02-24T05:14:45 [ERROR] thread 'main' panicked at 'already mutably borrowed: BorrowError': /Users/administrator/actions-org-runner/_work/zed/zed/crates/gpui/src/app.rs:398   0: backtrace::capture::Backtrace::new
   1: Zed::init_panic_hook::{{closure}}
   2: std::panicking::rust_panic_with_hook
   3: std::panicking::begin_panic_handler::{{closure}}
   4: std::sys_common::backtrace::__rust_end_short_backtrace
   5: _rust_begin_unwind
   6: core::panicking::panic_fmt
   7: core::result::unwrap_failed
   8: gpui::app::WeakModelHandle<T>::upgrade
   9: lsp::LanguageServer::on_custom_notification::{{closure}}
  10: <util::LogErrorFuture<F> as core::future::future::Future>::poll
  11: gpui::executor::any_local_future::{{closure}}
  12: async_task::raw::RawTask<F,T,S>::run
  13: <unknown>
  14: <unknown>
  15: <unknown>
  16: <unknown>
  17: <unknown>
  18: <unknown>
  19: <unknown>
  20: <unknown>
  21: <unknown>
  22: <unknown>
  23: <unknown>
  24: <unknown>
  25: <unknown>
  26: <unknown>
  27: <unknown>
  28: <unknown>
  29: <unknown>
  30: project_panel::ProjectPanel::reveal_in_finder
  31: gpui::app::MutableAppContext::add_action_internal::{{closure}}
  32: gpui::app::MutableAppContext::handle_dispatch_action_from_effect::{{closure}}::{{closure}}
  33: gpui::app::MutableAppContext::update
  34: gpui::app::MutableAppContext::flush_effects
  35: gpui::app::MutableAppContext::register_platform_window::{{closure}}
  36: gpui::platform::mac::window::handle_view_event
  37: <unknown>
  38: <unknown>
  39: gpui::platform::mac::window::send_event
  40: <unknown>
  41: gpui::platform::mac::platform::send_event
  42: <unknown>
  43: <unknown>
  44: <gpui::platform::mac::platform::MacForegroundPlatform as gpui::platform::ForegroundPlatform>::run
  45: gpui::app::App::run
  46: Zed::main
  47: std::sys_common::backtrace::__rust_begin_short_backtrace
  48: std::rt::lang_start::{{closure}}
  49: std::rt::lang_start_internal
  50: _main
@TENX-S TENX-S added defect [core label] triage Maintainer needs to classify the issue labels Feb 24, 2023
@TENX-S TENX-S changed the title Zed crashes when click “Reveal in Finder” more than once in full screen mode Zed crashes when click “Reveal in Finder” Feb 24, 2023
@JosephTLyons JosephTLyons added panic / crash [core label] urgent Issue that needs immediate attention and removed triage Maintainer needs to classify the issue labels Feb 24, 2023
@JosephTLyons JosephTLyons removed the urgent Issue that needs immediate attention label Mar 6, 2023
@mikayla-maki
Copy link
Contributor

this should be fixed now, let us know if you see it again!

@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] panic / crash [core label]
Projects
None yet
Development

No branches or pull requests

3 participants