Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video link in RSS #836

Open
jcmag opened this issue Apr 14, 2023 · 7 comments
Open

video link in RSS #836

jcmag opened this issue Apr 14, 2023 · 7 comments
Labels
enhancement New feature or request rss RSS-related issues

Comments

@jcmag
Copy link

jcmag commented Apr 14, 2023

Hi,

In case of a video, the RSS feed just contains a link to a thumbnail picture. Would it be possible to add a link to the video?

@zedeus zedeus added enhancement New feature or request rss RSS-related issues labels Jun 17, 2023
@ramhejazi
Copy link

I second this. I was going to open an issue regarding this. Adding an enclosure entry to RSS items for videos can make the RSS feature much more useful. This will also, probably, reduce the amount of scraping done by some users as they will have a better way of accessing information.

@markcellus
Copy link

Yeah, and some RSS readers will actually download the enclosure and let you play the video right inside of the RSS reader. 👍

@shirser121
Copy link

I second this. I was going to open an issue regarding this. Adding an enclosure entry to RSS items for videos can make the RSS feature much more useful. This will also, probably, reduce the amount of scraping done by some users as they will have a better way of accessing information.

Can i ask where this is standing?

@shelomito12
Copy link

This would be really nice to have in RSS feeds... any ETA on this?

@fnxweb
Copy link

fnxweb commented Dec 1, 2023

Dup of #421 ?

@zedeus
Copy link
Owner

zedeus commented Dec 4, 2023

Not quite, that issue is specifically about not needing to click the link.

@thomas-333
Copy link

In case anyone is interested, this is what I'm running on my personal instance to make it obvious when there is an embedded video:

diff --git a/src/views/rss.nimf b/src/views/rss.nimf
index 9324e75..4daad1a 100644
--- a/src/views/rss.nimf
+++ b/src/views/rss.nimf
@@ -38,7 +38,10 @@ Twitter feed for: ${desc}. Generated by ${cfg.hostname}
 <img src="${urlPrefix}${getPicUrl(photo)}" style="max-width:250px;" />
 #  end for
 #elif tweet.video.isSome:
-<img src="${urlPrefix}${getPicUrl(get(tweet.video).thumb)}" style="max-width:250px;" />
+<a href="${urlPrefix}${getLink(tweet)}">
+    <img src="${urlPrefix}${getPicUrl(get(tweet.video).thumb)}" style="max-width:250px;" />
+    <br>Click for video
+</a>
 #elif tweet.gif.isSome:
 #  let thumb = &"{urlPrefix}{getPicUrl(get(tweet.gif).thumb)}"
 #  let url = &"{urlPrefix}{getPicUrl(get(tweet.gif).url)}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rss RSS-related issues
Projects
None yet
Development

No branches or pull requests

8 participants