Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added message that the bookmark list is empty, fixed reopening of the same fragment #11

Merged
merged 3 commits into from May 26, 2020
Merged

Conversation

GeorgCantor
Copy link
Contributor

@GeorgCantor GeorgCantor commented May 25, 2020

Added message that the bookmark list is empty.
Fixed reopening of the same fragment. Now, when you click on the same drawer item again, the fragment does not reopen.
Added showing progress while a high quality image is loading.

@GeorgCantor GeorgCantor changed the title Added message that the bookmark list is empty Added message that the bookmark list is empty, fixed reopening of the same fragment May 25, 2020
@zedlabs
Copy link
Owner

zedlabs commented May 26, 2020

Fixed reopening of the same fragment. Now, when you click on the same drawer item again, the fragment does not reopen.

what do you mean by reopening fragment, I tested this PR and it was reloading on click.
Also, reloading on clicking was a design choice.

@GeorgCantor
Copy link
Contributor Author

Fixed reopening of the same fragment. Now, when you click on the same drawer item again, the fragment does not reopen.

what do you mean by reopening fragment, I tested this PR and it was reloading on click.
Also, reloading on clicking was a design choice.

If you have a fragment with Bookmarks open and you click on the bookmarks in the menu again, then this fragment reopens and is added to the stack. I did a check if the fragment is already open so that it does not open again

@zedlabs zedlabs merged commit 0cc72af into zedlabs:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants