Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Visual Width of Tab Characters in Edge Cases #71

Closed
kevinmatthes opened this issue Jul 26, 2022 · 2 comments
Closed

[Bug] Visual Width of Tab Characters in Edge Cases #71

kevinmatthes opened this issue Jul 26, 2022 · 2 comments

Comments

@kevinmatthes
Copy link
Contributor

Most languages in the config.ron are configured to indent using spaces, at the moment. When opening a file indented by tabs in a language configured to indent by spaces, the tab characters are displayed with visual width one instead of the configured width. Since other editors apply the configured width onto tabs visually, I would consider this a bug.

@iainh
Copy link
Contributor

iainh commented Jul 27, 2022

Kevin,

Have a look at PR #72, in my testing this change fixed the issue if I've understood the description. The problem as I see it is that the tab width was always returning 1 when the indentation unit was 'space' rather than returning the indentation width to visually appear correct.

@kevinmatthes
Copy link
Contributor Author

Thank you, #72 is indeed the solution to this issue. I reviewed and approved your Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants