Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Interpreter exceptions cause memory leaks #166
Created by Johanna Amann at 2012-06-08T18:51:11.569-0500:
To reproduce run bro using 2009-M57-day11-18.trace. pprof output is attached.
Comment by Robin Sommer at 2012-06-11T10:21:02.731-0500:
Comment by Jon Siwek at 2012-06-11T10:24:15.970-0500:
Yeah, I think I know what's going on, might have a patch shortly.
Comment by Jon Siwek at 2012-06-11T15:00:35.602-0500:
Would it be better to wait and fix this through overhauling memory management to use smart pointers? That's planned, right? Any script that tries to reference a missing field should be corrected, anyway (these errors are logged in reporter.log).
Comment by Robin Sommer at 2012-06-18T13:58:43.261-0500:
Regarding smart pointers, yes, in principle, but that's a big task, with potential to introduce very subtle problems. So while it's on the roadmap, I'm actually reluctant to tackle it soon. Also, perhaps this can be taken core of by eventually compiling Bro scripts, which will remove lots of the relevant code anyway long-term. But that's all something for a longer discussion.
I'm leaving this ticket open, but I'm removing the milestone.
Comment by Johanna Amann at 2015-10-19T15:38:07.706-0500: