Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String with embedded NUL Errors related to IRC(ish) traffic analysis #297

Open
dwdixon opened this Issue Feb 28, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@dwdixon
Copy link

dwdixon commented Feb 28, 2019

Hi there, I've also been seeing this error for many months now, first while running master prior to the official release of 2.6.1, but after moving to running 2.6.1 release I noticed that I'm still seeing this error, it looks like the NUL maybe isn't handled properly? I'm not totally sure, even though the NUL I don't think is supposed to be there (probably not following the RFC for the IRC protocol)... is throwing this error the proper way to address/handle that?

Reporter::ERROR string with embedded NUL: "jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00BYE"     (empty)
Reporter::ERROR string with embedded NUL: "P\\x00\\x01*ACK"     (empty)
Reporter::ERROR string with embedded NUL: "P\\x00\\x01\\xaaMESSAGE"     (empty)
Reporter::ERROR string with embedded NUL: "P\\x00\\x01XMESSAGE" (empty)
Reporter::ERROR string with embedded NUL: "P\\x00\\x01oMESSAGE" (empty)
Reporter::ERROR string with embedded NUL: "P\\x00\\x01*ACK"     (empty)
Reporter::ERROR string with embedded NUL: "P\\x00\\x01*ACK"     (empty)
Reporter::ERROR string with embedded NUL: "P\\x00\\x01_INVITE"  (empty)
Reporter::ERROR string with embedded NUL: "jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00REGISTER"      (empty)
Reporter::ERROR string with embedded NUL: "jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00jaK\\x00\\x00\\x00\\x00\\x00REGISTER"      (empty)
@jsiwek

This comment has been minimized.

Copy link
Member

jsiwek commented Mar 7, 2019

Hi, it is possibly indicating some bug or improvement that could be made, but it's hard to tell from just the error messages which code path is responsible for emitting them. It would be best if you could provide a pcap file that reproduces the errors, or, if you can't share that, give a call stack trace that pinpoints file/line information to pinpoint where those errors are generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.