Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish gps-share on crates.io #24

Closed
henry-nicolas opened this issue Apr 9, 2021 · 6 comments
Closed

Publish gps-share on crates.io #24

henry-nicolas opened this issue Apr 9, 2021 · 6 comments

Comments

@henry-nicolas
Copy link

Dear @zeenix ,

Could you please consider publishing gps-share on crates.io?
We have some automation for Rust package managment, downstream at Debian, but it rely on crates.io to pull the crates.

That would ease the downstream packaging of gps-share for Debian and its derivative.

Thanks and best regards,

@zeenix
Copy link
Owner

zeenix commented Apr 10, 2021

Sure but I don't have time right now.

@zeenix
Copy link
Owner

zeenix commented Apr 13, 2021

@henry-nicolas I can find some time to roll out a release in the coming days but I'm very reluctant to do so w/o automated tests (given that I don't have time test it manually myself). If you (or anyone from your company) could help with the following, that'd greatly help me roll out the release:

  1. basic e2e automated tests.
  2. update of the readme, to reflect:
    • the recently added enhancements
    • dependencies (we no longer use dbus-rs crate)

@dcz-purism
Copy link
Contributor

Which tests would you like to see contributed? I can see something like feeding gps-share a stream and seeing if it is multiplied correctly, but I don't really have an idea for testing a serial connection without dedicated test hardware.

@zeenix
Copy link
Owner

zeenix commented Apr 24, 2021

Which tests would you like to see contributed? I can see something like feeding gps-share a stream and seeing if it is multiplied correctly, but I don't really have an idea for testing a serial connection without dedicated test hardware.

Right, you'll need to mock the hardware here. We already have some very basic test using the stdin source and we can continue to use that source for tests. Some tests with real hardware would be great too but they could be disabled by default (through a Cargo feature perhaps) so we don't run them in the CI but on dev machine, they can be used at least.

@zeenix
Copy link
Owner

zeenix commented Apr 28, 2021

@henry-nicolas Thanks to your engineers' help, we are now live on crates.io. :)

@zeenix zeenix closed this as completed Apr 28, 2021
@henry-nicolas
Copy link
Author

Thanks @zeenix that is great news and thanks @dcz-purism for the test cases implementation.
To be fair, I am just a community member, I work on packaging for downstream distros (ie: debian and derivates), so credits goes to dcz and yourself ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants