Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements on the CI #54

Closed
lleontop opened this issue Oct 23, 2018 · 2 comments
Closed

Minor improvements on the CI #54

lleontop opened this issue Oct 23, 2018 · 2 comments

Comments

@lleontop
Copy link

Hi! Thank you for your great tool!

I would like to propose some minor improvements on the building/CI.
Firstly it would be great to have a Dockerfile that builds and runs the kube-scope in a multi layer docker build so as to be easier for someone to download and use the tool without having to setup GO in his/her env (or easily test some changes when changing code).

Secondly based on the above you could have circle CI pushing the latest code under a latest tag on DockerHub so someone doesn't even has to build anything, just gets the docker image and starts using the latest code of the tool.

I have done both of the above in the past so I would be more than happy to contribute if you think these proposals could be useful.

@zegl
Copy link
Owner

zegl commented Oct 31, 2018

@lleontop Hey, thanks for reaching out.

I have added (in #58 and #61) a step to the CI that automatically pushes a new :latest after every merge to master. I'd like to hear your feedback on it. :)

@zegl zegl closed this as completed Oct 31, 2018
@lleontop
Copy link
Author

lleontop commented Nov 1, 2018

Hi @zegl ! It looks great! Now I can officially use your latest fixes without waiting for a release :).

I was just wondering though why did you choose the multiple ADD commands for each folder instead of a single ADD/COPY in the first stage? In a test that I did COPY . . was also working also fine unless I am missing something!

Thanks again for the great tool and fast support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants