Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): disable dropdown follow parent width #241

Merged
merged 2 commits into from May 28, 2020
Merged

feat(select): disable dropdown follow parent width #241

merged 2 commits into from May 28, 2020

Conversation

unix
Copy link
Member

@unix unix commented May 28, 2020

PR Checklist

  • Fix linting errors
  • Label has been added

Change information

resolved #239

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #241 into rc will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               rc     #241   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         172      172           
  Lines        2181     2182    +1     
  Branches      515      516    +1     
=======================================
+ Hits         2180     2181    +1     
  Misses          1        1           
Impacted Files Coverage Δ
components/select/select-dropdown.tsx 100.00% <ø> (ø)
components/select/select-option.tsx 100.00% <ø> (ø)
components/select/select.tsx 100.00% <ø> (ø)
components/shared/dropdown.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8404ced...0509aad. Read the comment docs.

@unix unix merged commit 768a0c4 into geist-org:rc May 28, 2020
@unix unix deleted the dropdown branch May 28, 2020 02:36
@unix unix linked an issue May 28, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[select] dropdown auto width
1 participant