Skip to content

Commit

Permalink
Fix a regression introduced by #1058
Browse files Browse the repository at this point in the history
Such regression broke the character composition/paste on macOS
  • Loading branch information
matheuss committed Dec 2, 2016
1 parent e31f975 commit 6508d05
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions app/accelerators.js
Expand Up @@ -102,7 +102,6 @@ for (const key in allAccelerators) {
// decides if a keybard event is a Hyper Accelerator
function isAccelerator(e) {
let keys = [];
console.log(e);
if (!e.ctrlKey && !e.metaKey && !e.altKey) {
// all accelerators needs Ctrl or Cmd or Alt
return false;
Expand Down Expand Up @@ -130,7 +129,6 @@ function isAccelerator(e) {
}

keys = keys.join('+');

return cache.includes(keys);
}

Expand Down
2 changes: 1 addition & 1 deletion lib/hterm.js
Expand Up @@ -166,7 +166,7 @@ hterm.Keyboard.prototype.onKeyDown_ = function (e) {
e.preventDefault();
}

if (isAccelerator(e)) {
if (e.altKey || e.metaKey || isAccelerator(e)) {
// hterm shouldn't consume a hyper accelerator
return;
}
Expand Down

0 comments on commit 6508d05

Please sign in to comment.